Differential D5821
Add additional validation for start date and end date timezones Authored by dgibson on Tue, Jan 5, 8:24 PM. Tags None Subscribers None
Details
Based on rex's good suggestion here: https://dagster.phacility.com/D5814 Be more aggressive about timezone validation - if you set one, and you set a timezone on your start time or end time, it should match up with the execution timezone. Otherwise it's highly likely that your schedule will not be starting or ending where you expect. BK
Diff Detail
Event Timeline
Comment Actions would consider downgrading the pendulum instance error check to a warning, but this seems fine Comment Actions the problem is that there's no way to validate or verify the timezone name if they're using some other tzinfo - the tzinfo spec is... quite bad. "https://docs.python.org/3/library/datetime.html#datetime.tzinfo.tzname" ("Nothing about string names is defined by the datetime module, and there’s no requirement that it mean anything in particular. For example, “GMT”, “UTC”, “-500”, “-5:00”, “EDT”, “US/Eastern”, “America/New York” are all valid replies") Comment Actions OK, I ended up rethinking this a bit, rather than being very strict about exactly what comes in, transform it into a Pendulum timezone Comment Actions I think this is in a slightly confusing state, I would guess due to how it started vs the latest approach. Sending to you for one more spin for some mix of more tests or renaming / rewording
| ||||||||||||||||||||||||||||