Page MenuHomeElementl

[dagit] Information header on RunRoot
ClosedPublic

Authored by dish on Jan 4 2021, 11:38 PM.

Details

Summary

A proposed change to the header of a single Run view, to expose more metadata about the run. Images attached, and should be fairly self-explanatory.

Test Plan

View runs locally, verify proper rendering and behavior of each section.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2021, 11:44 PM
Harbormaster failed remote builds in B23606: Diff 28705!
dish requested review of this revision.Jan 5 2021, 3:13 PM

this seems great to me. Surprised run config was not available already, that seems extremely useful!

bengotow added inline comments.
js_modules/dagit/src/runs/RunDetails.tsx
32

Oh interesting I hadn't noticed we exported browerTimezone(). I think this should probably respect the timezone the user selected in the bottom left of the UI? I don't think we should really be using browserTimezone as currently implemented anywhere except in parenthesis beside "Automatic" in the timezone picker and in the super-expanded timestamp display where the time is shown in both the selected TZ and the default TZ.

Maybe this can use <TimestampDisplay unix={run.stats.startTime} />?

80

Not sure what this looks like but it might be nice to run ? <Group /> : "Loading" here so that we don't need to unwrap the run optional in a bunch of places here!

This revision is now accepted and ready to land.Jan 6 2021, 4:33 PM
js_modules/dagit/src/runs/RunDetails.tsx
32

Good catch, will fix these.

Consolidate 'loading' code a bit, use TimestampDisplay

Some cleanup for started/ended strings.

dish retitled this revision from [dagit] RFC: Information header on RunRoot to [dagit] Information header on RunRoot.Jan 6 2021, 9:01 PM
This revision was automatically updated to reflect the committed changes.