A proposed change to the header of a single Run view, to expose more metadata about the run. Images attached, and should be fairly self-explanatory.
Details
Details
View runs locally, verify proper rendering and behavior of each section.
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
this seems great to me. Surprised run config was not available already, that seems extremely useful!
| js_modules/dagit/src/runs/RunDetails.tsx | ||
|---|---|---|
| 32 | Oh interesting I hadn't noticed we exported browerTimezone(). I think this should probably respect the timezone the user selected in the bottom left of the UI? I don't think we should really be using browserTimezone as currently implemented anywhere except in parenthesis beside "Automatic" in the timezone picker and in the super-expanded timestamp display where the time is shown in both the selected TZ and the default TZ. Maybe this can use <TimestampDisplay unix={run.stats.startTime} />? | |
| 80 | Not sure what this looks like but it might be nice to run ? <Group /> : "Loading" here so that we don't need to unwrap the run optional in a bunch of places here! | |
| js_modules/dagit/src/runs/RunDetails.tsx | ||
|---|---|---|
| 32 | Good catch, will fix these. | |