Page MenuHomePhabricator
Differential D5796

Modernize dagstermill test setup
ClosedPublic
Actions

Authored by max on Mon, Jan 4, 8:32 PM.

Details

Reviewers
schrockn
alangenfeld
prha
Commits
R1:c5aad372a839: Modernize dagstermill test setup
Summary

Use contemporary APIs in test

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Mon, Jan 4, 8:32 PM
max added reviewers: schrockn, alangenfeld, prha.Mon, Jan 4, 8:34 PM
max updated this revision to Diff 28669.Mon, Jan 4, 8:38 PM

lint

Harbormaster failed remote builds in B23575: Diff 28665!Mon, Jan 4, 8:46 PM
Harbormaster completed remote builds in B23579: Diff 28669.Mon, Jan 4, 8:54 PM
max requested review of this revision.Mon, Jan 4, 8:54 PM
max added a child revision: D5811: Intermediate storage-based dagstermill impl.Tue, Jan 5, 6:08 PM
alangenfeld accepted this revision.Tue, Jan 5, 8:07 PM

cleanup

python_modules/libraries/dagstermill/dagstermill/serialize.py
4–40

i forgot about /never saw this spooky zone - out of scope for this diff but we should figure out the Right Way (tm) to do this

This revision is now accepted and ready to land.Tue, Jan 5, 8:07 PM
max added inline comments.Tue, Jan 5, 8:20 PM
python_modules/libraries/dagstermill/dagstermill/serialize.py
4–40

next diff!

max updated this revision to Diff 28790.Tue, Jan 5, 10:32 PM

rebase

Harbormaster completed remote builds in B23673: Diff 28790.Tue, Jan 5, 10:49 PM
Closed by commit R1:c5aad372a839: Modernize dagstermill test setup (authored by max). · Explain WhyTue, Jan 5, 10:51 PM
This revision was automatically updated to reflect the committed changes.
max added a commit: R1:c5aad372a839: Modernize dagstermill test setup.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagstermill/
dagstermill/
examples/
429 lines
7 lines
6 lines
dagstermill_tests/
74 lines
2 lines
25 lines
17 lines

Diff 28793

View Options

python_modules/libraries/dagstermill/dagstermill/examples/repository.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill/manager.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill/serialize.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_basic_dagstermill_solids.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_event_callback.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_logging.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_manager.py

Loading...