Page MenuHomePhabricator

Remove six.with_metaclass
ClosedPublic

Authored by nate on Thu, Dec 31, 6:03 PM.

Details

Summary

also lets us remove the pylint ignore

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Dec 31, 6:31 PM
Harbormaster failed remote builds in B23528: Diff 28604!
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Dec 31, 11:33 PM
Harbormaster failed remote builds in B23531: Diff 28607!
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Dec 31, 11:57 PM
Harbormaster failed remote builds in B23532: Diff 28608!
nate requested review of this revision.Fri, Jan 1, 12:16 AM
nate added a reviewer: alangenfeld.
max added inline comments.
python_modules/dagster/dagster/core/executor/child_process_executor.py
49

what's going on here? was this just a missing init where the pylint error was being swallowed?

This revision is now accepted and ready to land.Mon, Jan 4, 4:25 PM
python_modules/dagster/dagster/core/executor/child_process_executor.py
49

yeah, when I removed that global pylint ignore this started failing. I could add it here, but figured it'd be best to just do the right thing and call super init ¯\_(ツ)_/¯

This revision was automatically updated to reflect the committed changes.