whats the error here

this thing haunts my dreams

whats up with these?

we should figure out a way not to require this or have a comment

The issue is that the set of attrs is "computed" - i.e. SOLID_DEF_HEADER_PROPS is defined elsewhere and then referenced here. Mypy is smart enough to infer the set of attributes for a namedtuple if they're hardcoded where it's defined, but not smart enough to run the code that computes them.

So we could also fix this by just inlining the value of SOLID_DEF_HEADER_PROPS.

mypy was complaining about that this sets an attr that doesn't exist: https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster_tests/core_tests/storage_tests/test_schedule_storage.py#L15

we can probably remove the `TestScheduleStorage.test = False" now that we have this. I'll do that,

Definitely agree that we should figure out a way to not require this. Are you saying that we should do that in this diff or down the road?

You are probably already aware of this, but this is following what we recommend users do: https://docs.dagster.io/tutorial/types#mypy-compliance.

let's just inline them then

Yeah I feel increasingly bad about recommending that. IMO, you want to use Dagster types alongside mypy we should just be using InputDefinition and OutputDefinition everywhere (with the possible exception of built-ins), but I think I might be in the minority there.