Page MenuHomeElementl

Run mypy on dagster core
AbandonedPublic

Authored by max on Dec 23 2020, 3:21 AM.

Details

Summary

All is bright

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
type-check
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 23 2020, 3:42 AM
Harbormaster failed remote builds in B23403: Diff 28472!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 23 2020, 9:27 AM
Harbormaster failed remote builds in B23404: Diff 28473!
max requested review of this revision.Dec 23 2020, 6:23 PM

This is stacked on D5761 because that gets rid of some of the most mypy-unfriendly parts of our codebase.

will let @sandyryza resolve this and D5768

python_modules/dagster/mypy.ini
4

what is the behavior if we don't pin to a specific version?

schrockn requested changes to this revision.Jan 4 2021, 4:48 PM

Please see comment on https://dagster.phacility.com/D5768 I would like to have a plan and messaging in place for the team before we merge this.

This revision now requires changes to proceed.Jan 4 2021, 4:48 PM
max planned changes to this revision.Jan 4 2021, 8:14 PM
max planned changes to this revision.Jan 4 2021, 8:15 PM
python_modules/dagster/mypy.ini
4

it will use the version of the interpreter that's running mypy.

https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version

python_modules/dagster/mypy.ini
2

We use a single .pylintrc across all modules. What do you think about doing the same here?

cool stuff. looking forward to this landing!

python_modules/dagster/mypy.ini
2

fine with that, i was just trying to be conservative