Page MenuHomePhabricator

Clean up legacy 2/3 compat
ClosedPublic

Authored by max on Tue, Dec 22, 11:57 PM.

Details

Summary

Removes the most awful code (conditional imports/reassignments) from dagster.seven

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max published this revision for review.Tue, Dec 22, 11:57 PM

Lint issues are spurious

max planned changes to this revision.Wed, Dec 23, 12:02 AM

Lint issues are artifacts of my local environment

thanks for cleaning up

cleanup

python_modules/dagster/dagster/seven/json.py
13 ↗(On Diff #28615)

nit: wrong diff for this i think

This revision is now accepted and ready to land.Mon, Jan 4, 4:39 PM
This revision was landed with ongoing or failed builds.Mon, Jan 4, 6:48 PM
This revision was automatically updated to reflect the committed changes.