Page MenuHomeElementl

Make DagsterDaemonScheduler the default scheduler
ClosedPublic

Authored by dgibson on Dec 22 2020, 10:57 PM.

Details

Summary

Now that we have heartbeats on the daemons page I think it is reasonable to make this the default. We should think about what kind of affordances we might want to put into dagit that prompt people to go deploy the daemon though.

Test Plan

BK, launch dagit with empty dagster.yaml

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2020, 11:18 PM
Harbormaster failed remote builds in B23381: Diff 28445!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 23 2020, 1:56 AM
Harbormaster failed remote builds in B23398: Diff 28467!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 23 2020, 2:23 AM
Harbormaster failed remote builds in B23399: Diff 28468!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 23 2020, 2:55 AM
Harbormaster failed remote builds in B23401: Diff 28470!

We should think about what kind of affordances we might want to put into dagit that prompt people to go deploy the daemon though.

my initial reaction is hesitancy to land this if we are not happy yet with the user experience of turning a schedule on and it not running because there is no daemon going - what is that current experience like?

seems like we could make a UI affordance the use case where you turn on the schedule without a daemon process running

@alangenfeld in master today you'll see a red warning next to the scheduler daemon saying it never ran (or when the last time it ran was)

nosched.png (632×1 px, 147 KB)

alright thats an acceptable enough base line i think - and chances are it will improve a little before launch

This revision is now accepted and ready to land.Jan 4 2021, 5:25 PM