Page MenuHomeElementl

Type hints for check
ClosedPublic

Authored by max on Dec 22 2020, 7:22 PM.

Details

Summary

And to all a good night!!

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2020, 7:36 PM
Harbormaster failed remote builds in B23353: Diff 28407!
max requested review of this revision.Dec 22 2020, 8:27 PM

noice

does the our existing mypy check in buildkite exercise this? should we add a step?

Yeah would like to have a clear plan for actually turning on mypy. Adding typehints without automated checks is worse than having no typehints imo

I suppose I was assuming everyone was running mypy locally -- I can add a mypy check in a separate diff.

Never assume anything is happening locally if it doesn’t happen in the ci/cd pipeline :-)

Sent via Superhuman iOS ( https://sprh.mn/?vip=schrockn@elementl.com )

This revision is now accepted and ready to land.Jan 4 2021, 4:24 PM
This revision was automatically updated to reflect the committed changes.