Page MenuHomeElementl

More consistent modals for “Show JSON”, “Show MD”, whitespace in “Copy”
ClosedPublic

Authored by bengotow on Dec 21 2020, 11:00 PM.

Details

Summary

Small diff containing the misc improvements I made while working on D5637.

  • If you click "Copy" while viewing a materialization event metadata value, we now preserve whitespace in the original text via innerText (vs textContent)
  • The "Show JSON", "Show Markdown", etc. buttons now use a standard modal styling and do not use our custom alert provider, which means that they can appear from within the "View Details" modal without dismissing it.
Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable