Page MenuHomeElementl

Eliminate pipeline_def from InitResourceContext
ClosedPublic

Authored by schrockn on Dec 19 2020, 6:58 PM.

Details

Summary

Preparing for a future where pipelines are no longer required
for things. I've encountered this both in the context of preparing the
graph/pipeline merge as well as making solids independently executable
in a first class way. I was pleasantly surprised to see that this did
not break any tests. The question is how defensive we want to be here.
Do we think this will break users?

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I would guess that this is safe to drop without impacting anyone at this point.

That said, do we not anticipate having whatever the root definition being executed is captured in this context? If we have that then having a pipeline_def accessor that returns it if its an instance of pipeline_def would be a more friendly path.

I would rather eliminate it as I anticipate that we will add resources other artifacts like sensors to enable local dev and testing. This change makes this abstraction applicable across other axes than just graphs

alright just log a changes.md entry

This revision is now accepted and ready to land.Dec 21 2020, 5:09 PM