Page MenuHomePhabricator
Differential D5679

Cleans env markers for unsupported Python versions.
AbandonedPublic
Actions

Authored by bob on Dec 17 2020, 10:13 PM.

Details

Reviewers
sashank
nate
Summary

Remove environment markers from requirement constraints in setup.py install_requires.

Any environment markers for Python <3.6 should be removed and/or simplified.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
bob--clean-py-version-checks-setuppy
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

bob created this revision.Dec 17 2020, 10:13 PM
Harbormaster completed remote builds in B23141: Diff 28140.Dec 17 2020, 10:34 PM
bob requested review of this revision.Dec 17 2020, 10:34 PM
nate added inline comments.Dec 17 2020, 10:39 PM
python_modules/dagit/setup.py
42–43

can rm this comment too

42–43

I think we can drop future now!

python_modules/dagster/setup.py
55–56

can remove future and python 2 comment also here

83

I feel like this could be relaxed to >=0.7.1

nate added a comment.Dec 17 2020, 10:40 PM

prob worth checking for future in other libraries

sashank added a comment.Dec 18 2020, 3:05 PM

Looks great to me, I'll let Nate do the final sign off

bob updated this revision to Diff 28229.Dec 18 2020, 7:48 PM
  • Removes "future" dependency.
Harbormaster failed remote builds in B23214: Diff 28229!Dec 18 2020, 7:59 PM
bob updated this revision to Diff 28644.Mon, Jan 4, 6:00 PM

rebase on master

Harbormaster failed remote builds in B23559: Diff 28644!Mon, Jan 4, 6:12 PM
bob abandoned this revision.Mon, Jan 4, 7:03 PM

these changes are a subset of this commit

Revision Contents
Changeset List

PathSize
python_modules/
automation/
6 lines
dagit/
3 lines
dagster/
13 lines
libraries/
dagster-airflow/
2 lines
dagster-gcp/
2 lines

Diff 28644

View Options

python_modules/automation/setup.py

Loading...
View Options

python_modules/dagit/setup.py

Loading...
View Options

python_modules/dagster/setup.py

Loading...
View Options

python_modules/libraries/dagster-airflow/setup.py

Loading...
View Options

python_modules/libraries/dagster-gcp/setup.py

Loading...