Page MenuHomePhabricator
Differential D5654

remove the option to backfill from failure
Needs ReviewPublic
Actions

Authored by catherinewu on Dec 17 2020, 5:20 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

remove the option to backfill from failure from the partitions ui. this is a temporary fix. the underlying issue is that the run query does a full table scan or run tags

Test Plan

manual

Diff Detail

Repository
R1 dagster
Branch
remove-from-failure
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

catherinewu created this revision.Dec 17 2020, 5:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2020, 5:26 AM
Harbormaster failed remote builds in B23070: Diff 28054!
catherinewu updated this revision to Diff 28086.Dec 17 2020, 4:47 PM

yarn run generate-types

Harbormaster completed remote builds in B23095: Diff 28086.Dec 17 2020, 4:54 PM
catherinewu requested review of this revision.Dec 17 2020, 4:54 PM
catherinewu updated this revision to Diff 28088.Dec 17 2020, 4:56 PM

up

Harbormaster completed remote builds in B23097: Diff 28088.Dec 17 2020, 5:03 PM
sandyryza added a subscriber: sandyryza.Dec 18 2020, 6:29 PM

I think it will take a while until we can batchify our APIs, and it would be good to address the loading delay before then.

What I think we should do:

  • Get rid of "Re-execute From Last Run", because it's confusing and not super useful, as discussed here: https://github.com/dagster-io/dagster/issues/2989
  • Don't be smart about "Re-execute From Failure". Just have it always enabled. If there are no failures, don't kick off any runs.

@catherinewu - thoughts? I can pick this up if helpful.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
partitions/
56 lines
types/

Diff 28088

View Options

js_modules/dagit/src/partitions/PartitionsBackfill.tsx

Loading...
View Options

js_modules/dagit/src/partitions/types/PartitionsBackfillSelectorQuery.ts

Loading...