Page MenuHomeElementl

Add more detail to schedule logs command
ClosedPublic

Authored by sashank on Dec 17 2020, 3:54 AM.

Details

Summary

Previously, the schedule log command only showed the top level log file, which captured errors at the cron and bash script level. This diff updates the schedule log command to also link to the individual execution logs, which are needed to debug user-code error issues.

Test Plan

Run dagster schedule logs in the toys directory for (1) a schedule with result logs and (2) a schedule without result logs

Diff Detail

Repository
R1 dagster
Branch
fix-logs
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2020, 4:14 AM
Harbormaster failed remote builds in B23069: Diff 28053!
dgibson added inline comments.
python_modules/dagster/dagster/cli/schedule.py
373

not really related to this diff but should we also gate this function on specific schedulers? It doesn't work with the daemon scheduler for example - does it work with the k8s scheduler?

This revision is now accepted and ready to land.Dec 18 2020, 4:28 PM
python_modules/dagster/dagster/cli/schedule.py
373

yes we should, how do the logs for the daemon scheduler work?

This revision was automatically updated to reflect the committed changes.