Page MenuHomeElementl
Differential D5646

Log error/interrupt events in the execute_run CLI call
ClosedPublic
Actions

Authored by • dgibson on Dec 16 2020, 8:15 PM.
Tags
None
Referenced Files
F2988613: D5646.id28005.diff
Sun, Jun 4, 5:50 PM
Unknown Object (File)
Fri, Jun 2, 11:23 AM
Unknown Object (File)
Sun, May 28, 7:57 AM
Unknown Object (File)
Sun, May 7, 1:16 AM
Unknown Object (File)
Apr 6 2023, 3:13 PM
Unknown Object (File)
Mar 31 2023, 3:07 AM
Unknown Object (File)
Mar 21 2023, 12:28 PM
Unknown Object (File)
Mar 20 2023, 1:26 PM
View All 62 Files
Subscribers
None

Details

Reviewers
• johann
• nate
alangenfeld
Commits
R1:c24edab9f6ab: Log error/interrupt events in the execute_run CLI call
Summary

Getting errors surfaced here would be extremely useful fro debugging.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dgibson created this revision.Dec 16 2020, 8:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 16 2020, 8:44 PM
Harbormaster failed remote builds in B23021: Diff 27997!
• dgibson updated this revision to Diff 28003.Dec 16 2020, 8:45 PM

let's try this instead - log the exception event just like we log the other events

• dgibson updated this revision to Diff 28005.Dec 16 2020, 8:50 PM

up

• dgibson retitled this revision from RFC: Raise errors in the execute_run function to Log error/interrupt events in the execute_run CLI call.Dec 16 2020, 9:01 PM
• dgibson edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B23026: Diff 28003.Dec 16 2020, 9:03 PM
Harbormaster completed remote builds in B23028: Diff 28005.Dec 16 2020, 9:08 PM
• dgibson requested review of this revision.Dec 16 2020, 9:08 PM
• dgibson updated this revision to Diff 28040.Dec 16 2020, 10:56 PM

up

alangenfeld accepted this revision.Dec 16 2020, 11:00 PM

slamdunk

This revision is now accepted and ready to land.Dec 16 2020, 11:00 PM
Harbormaster completed remote builds in B23060: Diff 28040.Dec 16 2020, 11:16 PM
Closed by commit R1:c24edab9f6ab: Log error/interrupt events in the execute_run CLI call (authored by • dgibson). · Explain WhyDec 16 2020, 11:29 PM
This revision was automatically updated to reflect the committed changes.
• dgibson added a commit: R1:c24edab9f6ab: Log error/interrupt events in the execute_run CLI call.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
cli/
22 lines

Diff 28043

View Options

python_modules/dagster/dagster/cli/api.py

Loading...