Page MenuHomeElementl

deprecation warnings for intermediate storage config and defs
ClosedPublic

Authored by yuhan on Dec 15 2020, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 26, 9:51 PM
Unknown Object (File)
Tue, Jul 26, 2:00 AM
Unknown Object (File)
Sat, Jul 23, 12:00 AM
Unknown Object (File)
Jul 14 2022, 3:25 PM
Unknown Object (File)
Jun 27 2022, 7:11 AM
Unknown Object (File)
Jun 24 2022, 9:40 AM
Unknown Object (File)
Jun 24 2022, 6:25 AM
Unknown Object (File)
Jun 23 2022, 12:32 PM
Subscribers
None

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

MIGRATION.md
42–43

TODO: object_manager_from_intermediate_storage

I left a bunch of small comments.

What do you think about linking to the doc in the migration guide and warnings? Would probably need to determine the URL based on the version.

MIGRATION.md
7

Might also be helpful to mention that the intermediate_storage_defs argument on ModeDefinition is deprecated?

10

Nitpick: serve -> serves

11

Nitpick: output -> outputs

27

Nice

python_modules/dagster/dagster/core/definitions/intermediate_storage.py
38

Nitpick: is -> are

python_modules/dagster/dagster/core/system_config/objects.py
347

the -> The
entry -> entries
is -> are

348

remove "the".

The word "feature" kind of makes it sound like object managers are a bell or whistle, when in fact they're the abstraction underlying all input/output loading/storing. Consider replacing with something like 'Loading inputs and storing outputs are now handled by "object managers", which can be configured via...'?

This revision is now accepted and ready to land.Dec 17 2020, 12:50 AM

What do you think about linking to the doc in the migration guide and warnings?

Yes! I was planning to add the doc links once the related docs are released. will tag an issue to remind myself to do so

yuhan marked 5 inline comments as done.

comments