Page MenuHomeElementl

DynamicOutput enforce constraints
ClosedPublic

Authored by alangenfeld on Dec 15 2020, 4:52 AM.
Tags
None
Referenced Files
F2291091: D5612.id27832.diff
Thu, Jun 30, 11:52 PM
Unknown Object (File)
Tue, Jun 28, 11:41 PM
Unknown Object (File)
Sun, Jun 26, 7:10 PM
Unknown Object (File)
Sat, Jun 25, 8:55 PM
Unknown Object (File)
Sat, Jun 18, 5:56 AM
Unknown Object (File)
Fri, Jun 17, 4:33 PM
Unknown Object (File)
Mon, Jun 13, 2:18 AM
Unknown Object (File)
May 30 2022, 9:08 AM
Subscribers
None

Details

Summary

ensure that the current limitations of dynamic outputs are enforced with clear error messages.

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

cool. plz consider final comments

python_modules/dagster/dagster/core/definitions/dependency.py
459–479

slightly goofy for this to be an inner function given that you aren't capturing anything via closure. (I also thought you were somehow calling it recursively because hard to tell scope with python whitespace ish)

465–467

I'm having trouble parsing this error message

468–475

Not looking forward to explaining the subtleties of this distinction

476

output

476

mild preference for "cannot" rather than "can not"

477

probably should be a 2nd sentence or "as it is downstream"

This revision is now accepted and ready to land.Dec 15 2020, 5:14 PM
python_modules/dagster/dagster_tests/core_tests/mapping_tests/test_not_allowed.py
111–118

[2]

This revision was automatically updated to reflect the committed changes.