Page MenuHomeElementl

DynamicOutput enforce constraints
ClosedPublic

Authored by alangenfeld on Dec 15 2020, 4:52 AM.
Tags
None
Referenced Files
F2429019: D5612.id28961.diff
Sat, Aug 13, 4:40 AM
Unknown Object (File)
Thu, Aug 11, 6:48 PM
Unknown Object (File)
Wed, Aug 10, 8:19 PM
Unknown Object (File)
Wed, Aug 10, 12:04 PM
Unknown Object (File)
Mon, Aug 8, 7:48 AM
Unknown Object (File)
Mon, Aug 8, 4:37 AM
Unknown Object (File)
Mon, Aug 1, 8:33 AM
Unknown Object (File)
Mon, Aug 1, 1:49 AM
Subscribers
None

Details

Summary

ensure that the current limitations of dynamic outputs are enforced with clear error messages.

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Branch
edge
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

cool. plz consider final comments

python_modules/dagster/dagster/core/definitions/dependency.py
459–479

slightly goofy for this to be an inner function given that you aren't capturing anything via closure. (I also thought you were somehow calling it recursively because hard to tell scope with python whitespace ish)

465–467

I'm having trouble parsing this error message

476

output

476

mild preference for "cannot" rather than "can not"

477

probably should be a 2nd sentence or "as it is downstream"

490–497

Not looking forward to explaining the subtleties of this distinction

This revision is now accepted and ready to land.Dec 15 2020, 5:14 PM
python_modules/dagster/dagster_tests/core_tests/mapping_tests/test_not_allowed.py
111–118

[2]

This revision was automatically updated to reflect the committed changes.