ensure that the current limitations of dynamic outputs are enforced with clear error messages.
Details
Details
- Reviewers
catherinewu schrockn - Commits
- R1:2f9ca0165b05: DynamicOutput enforce constraints
added tests
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
cool. plz consider final comments
| python_modules/dagster/dagster/core/definitions/dependency.py | ||
|---|---|---|
| 457–477 | slightly goofy for this to be an inner function given that you aren't capturing anything via closure. (I also thought you were somehow calling it recursively because hard to tell scope with python whitespace ish) | |
| 463–465 | I'm having trouble parsing this error message | |
| 466–473 | Not looking forward to explaining the subtleties of this distinction | |
| 474 | output | |
| 474 | mild preference for "cannot" rather than "can not" | |
| 475 | probably should be a 2nd sentence or "as it is downstream" | |
| python_modules/dagster/dagster_tests/core_tests/mapping_tests/test_not_allowed.py | ||
|---|---|---|
| 110–117 ↗ | (On Diff #27832) | [2] |