Page MenuHomePhabricator

[dagster-k8s] Have job image from executor config take precedence instead of erroring
Needs RevisionPublic

Authored by sashank on Dec 14 2020, 5:52 PM.

Details

Summary

Instead of throwing an error, have a job image from executor config take precedence over a job image from a user code deployment. Also report an engine event to make it clear that this is happening.l

Test Plan

integration
newline

Diff Detail

Repository
R1 dagster
Branch
executor-config-image
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank edited the test plan for this revision. (Show Details)

can you test this? Manual is acceptable, integration test if you can come up with it

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/launcher.py
214–216

i think you want to be using f"" strings here if you want {variable_name} to interpolate correctly, this is just going to print the exact string "...job_image {job_image_from_executor_config}..."

This revision now requires changes to proceed.Dec 16 2020, 11:02 PM