Page MenuHomeElementl
Differential D555

Resolve pipelines from handles when executing through dagster-graphql
ClosedPublic
Actions

Authored by • max on Jul 8 2019, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 10, 9:14 AM
Unknown Object (File)
Apr 13 2023, 2:04 AM
Unknown Object (File)
Apr 13 2023, 2:03 AM
Unknown Object (File)
Apr 13 2023, 1:53 AM
Unknown Object (File)
Apr 13 2023, 1:48 AM
Unknown Object (File)
Apr 12 2023, 10:56 PM
Unknown Object (File)
Apr 12 2023, 2:39 PM
Unknown Object (File)
Apr 12 2023, 11:12 AM
View All Files
Subscribers
None

Details

Reviewers
alangenfeld
• nate
• schrockn
Commits
R1:41d43b6d81db: Resolve pipelines from handles when executing through dagster-graphql
Summary

Fixes an issue where dagstermill notebooks could not execute through dagster-graphql.

Test Plan

Manual

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Jul 8 2019, 5:23 PM
• max updated this revision to Diff 2633.Jul 8 2019, 5:25 PM

Error msg

alangenfeld accepted this revision.Jul 8 2019, 5:26 PM

redfordnod

This revision is now accepted and ready to land.Jul 8 2019, 5:26 PM
• max updated this revision to Diff 2635.Jul 8 2019, 5:49 PM

Multiprocessing fixes

• max updated this revision to Diff 2636.Jul 8 2019, 6:00 PM

Fix mode

Harbormaster failed remote builds in B2128: Diff 2633!Jul 8 2019, 6:28 PM
Harbormaster failed remote builds in B2127: Diff 2632!Jul 8 2019, 6:38 PM
• max updated this revision to Diff 2637.Jul 8 2019, 6:54 PM

Fixup loading

• max updated this revision to Diff 2638.Jul 8 2019, 6:58 PM

Black

• max updated this revision to Diff 2639.Jul 8 2019, 7:03 PM

Nits

Harbormaster failed remote builds in B2130: Diff 2636!Jul 8 2019, 7:04 PM
• nate accepted this revision.Jul 8 2019, 7:04 PM
Harbormaster failed remote builds in B2129: Diff 2635!Jul 8 2019, 7:07 PM
• max updated this revision to Diff 2640.Jul 8 2019, 7:10 PM

Lint

Harbormaster failed remote builds in B2132: Diff 2638!Jul 8 2019, 8:08 PM
Harbormaster failed remote builds in B2133: Diff 2639!Jul 8 2019, 8:13 PM
• max updated this revision to Diff 2641.Jul 8 2019, 8:13 PM

Eliminate now-irrelevant tests

• max updated this revision to Diff 2642.Jul 8 2019, 8:17 PM

Lint

Harbormaster failed remote builds in B2131: Diff 2637!Jul 8 2019, 8:20 PM
Harbormaster failed remote builds in B2134: Diff 2640!
Harbormaster failed remote builds in B2135: Diff 2641!Jul 8 2019, 8:25 PM
Harbormaster failed remote builds in B2136: Diff 2642!
• max updated this revision to Diff 2643.Jul 8 2019, 8:36 PM

Lint

• max updated this revision to Diff 2644.Jul 8 2019, 8:37 PM

Black

Harbormaster failed remote builds in B2137: Diff 2643!Jul 8 2019, 8:45 PM
Harbormaster completed remote builds in B2138: Diff 2644.Jul 8 2019, 8:55 PM
Closed by commit R1:41d43b6d81db: Resolve pipelines from handles when executing through dagster-graphql (authored by • max). · Explain WhyJul 8 2019, 9:03 PM
This revision was automatically updated to reflect the committed changes.
Max Gasner <max.gasner@gmail.com> added a commit: R1:41d43b6d81db: Resolve pipelines from handles when executing through dagster-graphql.

Revision Contents
Changeset List

PathSize
examples/
dagster_examples_tests/
graphql_tests/
2 lines
python_modules/
dagit/
dagit_tests/
20 lines
dagster-graphql/
dagster_graphql/
implementation/
18 lines
6 lines
7 lines
dagster/
dagster/
core/
definitions/
34 lines
dagster_tests/
cli_tests/
6 lines
dagstermill/
dagstermill/
2 lines

Diff 2646

View Options

examples/dagster_examples_tests/graphql_tests/test_examples_presets_graphql.py

Loading...
View Options

python_modules/dagit/dagit_tests/test_cli.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_pipelines.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/implementation/pipeline_execution_manager.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/handle.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/test_pipeline_repo_loads.py

Loading...
View Options

python_modules/dagstermill/dagstermill/manager.py

Loading...