Page MenuHomePhabricator

Get make dev_install working on python 3.9
ClosedPublic

Authored by max on Dec 10 2020, 9:47 PM.

Details

Test Plan

Manual, Python 3.9 test setup to follow

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 10 2020, 10:05 PM
Harbormaster failed remote builds in B22596: Diff 27470!
max requested review of this revision.Dec 11 2020, 9:42 PM

Macro pikachu:

examples/legacy_examples/dagster_examples/__init__.py
27

nit: could add warnings.warn("Bay bikes pipeline is not compatible with python version >= 3.9. Skipping")

This revision is now accepted and ready to land.Dec 11 2020, 11:10 PM
Makefile
24–108

this has become real real gnarly

53–87

is this the right place to do this hard pin?

53–88

is there a difference between installing them all in one versus one at time? I assumed it was more efficient to bundle them all in one install command

examples/legacy_examples/dagster_examples/__init__.py
26–39

I dont love this, its already in a neglected legacy_examples folder and now conditionally disappears - feels like we should just delete it if its this atrophied

python_modules/libraries/dagster-gcp/setup.py
39

should we tracking task these?

This revision was automatically updated to reflect the committed changes.