Page MenuHomeElementl

Add .join() to grpc server handle cleanup
AbandonedPublic

Authored by dgibson on Dec 9 2020, 5:34 PM.

Details

Reviewers
sashank
Summary

Attempt to get around weird sporadic crashes in BK

Test Plan

BK + pray

Diff Detail

Repository
R1 dagster
Branch
addjoin (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Add a bit more cleanup to mimic what the managed handle does (e.g. if the list repositories call fails - not quite as relevant here sicne we don't need to kill the server, but can't hurt)

sashank published this revision for review.Dec 9 2020, 5:44 PM

Thanks for this, this looks great

python_modules/dagster/dagster/core/host_representation/handle.py
125–127

👍 Good call

bringing this back for once the thread-safety issues are fixed in https://dagster.phacility.com/D5790 - since i think it's still a good change to clean up the thread

bring back the deployed_grpc test suites as well