Attempt to get around weird sporadic crashes in BK
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- addjoin (branched from master)
- Lint
Lint OK - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
Add a bit more cleanup to mimic what the managed handle does (e.g. if the list repositories call fails - not quite as relevant here sicne we don't need to kill the server, but can't hurt)
Comment Actions
Thanks for this, this looks great
python_modules/dagster/dagster/core/host_representation/handle.py | ||
---|---|---|
124β126 | π Good call |
Comment Actions
bringing this back for once the thread-safety issues are fixed in https://dagster.phacility.com/D5790 - since i think it's still a good change to clean up the thread