Page MenuHomeElementl

Attempt to recover when a run is terminated between being dequeued and execution is started
ClosedPublic

Authored by dgibson on Dec 8 2020, 4:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 16, 6:25 AM
Unknown Object (File)
Tue, Sep 13, 8:50 AM
Unknown Object (File)
Sun, Sep 11, 10:39 PM
Unknown Object (File)
Sun, Aug 28, 12:15 PM
Unknown Object (File)
Aug 26 2022, 11:39 AM
Unknown Object (File)
Aug 23 2022, 3:41 AM
Unknown Object (File)
Aug 20 2022, 6:18 AM
Unknown Object (File)
Aug 5 2022, 2:25 PM
Subscribers
None

Details

Summary

This isn't perfect, but should help with the case where we hard-terminate a run while it's in the middle of being popped off of the queue. Hopefully a rare case in the first place.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The difference in behavior is

  • better user message
  • no error raised?

yeah, that's correct. IMO we shouldn't fire an invariant violation if its something that can actually happen

This revision is now accepted and ready to land.Dec 8 2020, 7:04 PM
This revision is now accepted and ready to land.Dec 16 2020, 11:29 PM