Page MenuHomeElementl

default "asset_store" -> "object_manager"
ClosedPublic

Authored by sandyryza on Dec 8 2020, 12:47 AM.
Tags
None
Referenced Files
F2670801: D5472.diff
Sat, Nov 26, 3:19 AM
Unknown Object (File)
Mon, Nov 21, 1:25 AM
Unknown Object (File)
Wed, Nov 16, 11:38 AM
Unknown Object (File)
Wed, Nov 16, 2:30 AM
Unknown Object (File)
Sun, Nov 13, 5:51 AM
Unknown Object (File)
Mon, Nov 7, 10:33 PM
Unknown Object (File)
Mon, Oct 31, 11:40 AM
Unknown Object (File)
Oct 25 2022, 8:44 AM
Subscribers
None

Details

Diff Detail

Repository
R1 dagster
Branch
default-object-manager
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 1:04 AM
Harbormaster failed remote builds in B22360: Diff 27180!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 4:04 PM
Harbormaster failed remote builds in B22394: Diff 27218!

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

python_modules/dagster/dagster/core/storage/asset_store.py
33

materialize -> handle_output

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

Exactly.

python_modules/dagster/dagster/core/storage/asset_store.py
33

Oops, this snuck in from a different diff. Will fix separately.

This revision is now accepted and ready to land.Dec 9 2020, 12:53 AM