Page MenuHomeElementl

default "asset_store" -> "object_manager"
ClosedPublic

Authored by sandyryza on Dec 8 2020, 12:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 16, 9:51 AM
Unknown Object (File)
Fri, Sep 16, 3:59 AM
Unknown Object (File)
Sun, Sep 11, 10:08 AM
Unknown Object (File)
Aug 19 2022, 10:08 PM
Unknown Object (File)
Aug 19 2022, 4:08 PM
Unknown Object (File)
Aug 19 2022, 3:15 AM
Unknown Object (File)
Aug 18 2022, 5:00 AM
Unknown Object (File)
Aug 17 2022, 12:18 PM
Subscribers
None

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 1:04 AM
Harbormaster failed remote builds in B22360: Diff 27180!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 4:04 PM
Harbormaster failed remote builds in B22394: Diff 27218!

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

python_modules/dagster/dagster/core/storage/asset_store.py
33–34

materialize -> handle_output

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

Exactly.

python_modules/dagster/dagster/core/storage/asset_store.py
33–34

Oops, this snuck in from a different diff. Will fix separately.

This revision is now accepted and ready to land.Dec 9 2020, 12:53 AM