Page MenuHomeElementl

default "asset_store" -> "object_manager"
ClosedPublic

Authored by sandyryza on Dec 8 2020, 12:47 AM.

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 1:04 AM
Harbormaster failed remote builds in B22360: Diff 27180!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2020, 4:04 PM
Harbormaster failed remote builds in B22394: Diff 27218!

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

python_modules/dagster/dagster/core/storage/asset_store.py
33–34

materialize -> handle_output

is the plan to replace asset store with object manager? and this is the one the early diffs to achieve that?

Exactly.

python_modules/dagster/dagster/core/storage/asset_store.py
33–34

Oops, this snuck in from a different diff. Will fix separately.

This revision is now accepted and ready to land.Dec 9 2020, 12:53 AM
This revision was automatically updated to reflect the committed changes.