Resolves https://github.com/dagster-io/dagster/issues/3081
Instead of explicitly setting a command, we only set args for the k8s container. This is so the user can override the command if needed through their Docker entrypoint.
Details
Details
Summary
Test Plan
integration
x
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 4:21 PM2020-12-07 16:21:41 (UTC+0)
Harbormaster failed remote builds in B22313: Diff 27107!Dec 7 2020, 4:46 PM2020-12-07 16:46:28 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 4:53 PM2020-12-07 16:53:39 (UTC+0)
sashank retitled this revision from Use args to Move "dagster" command to "args" for k8s container object.Dec 7 2020, 5:05 PM2020-12-07 17:05:49 (UTC+0)
Harbormaster failed remote builds in B22318: Diff 27112!Dec 7 2020, 5:22 PM2020-12-07 17:22:02 (UTC+0)
Harbormaster failed remote builds in B22319: Diff 27114!Dec 7 2020, 5:22 PM2020-12-07 17:22:46 (UTC+0)
Harbormaster failed remote builds in B22321: Diff 27120!Dec 7 2020, 5:53 PM2020-12-07 17:53:38 (UTC+0)
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 5:56 PM2020-12-07 17:56:59 (UTC+0)
Harbormaster completed remote builds in B22329: Diff 27131.Dec 7 2020, 6:21 PM2020-12-07 18:21:29 (UTC+0)
This revision is now accepted and ready to land.Dec 8 2020, 4:43 AM2020-12-08 04:43:06 (UTC+0)
Closed by commit R1:edf52f5d8341: Move "dagster" command to "args" for k8s container object (authored by sashank). · Explain WhyDec 14 2020, 5:52 PM2020-12-14 17:52:48 (UTC+0)
This revision was automatically updated to reflect the committed changes.