Page MenuHomePhabricator

Move "dagster" command to "args" for k8s container object
ClosedPublic

Authored by sashank on Dec 7 2020, 4:05 PM.

Details

Summary

Resolves https://github.com/dagster-io/dagster/issues/3081

Instead of explicitly setting a command, we only set args for the k8s container. This is so the user can override the command if needed through their Docker entrypoint.

Test Plan

integration
x

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 4:21 PM
Harbormaster failed remote builds in B22311: Diff 27099!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 4:53 PM
Harbormaster failed remote builds in B22316: Diff 27110!
sashank retitled this revision from Use args to Move "dagster" command to "args" for k8s container object.Dec 7 2020, 5:05 PM
sashank edited the summary of this revision. (Show Details)
sashank added reviewers: catherinewu, rexledesma.
sashank edited the summary of this revision. (Show Details)

up

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 7 2020, 5:56 PM
Harbormaster failed remote builds in B22322: Diff 27121!
sashank published this revision for review.Dec 7 2020, 6:12 PM
This revision is now accepted and ready to land.Dec 8 2020, 4:43 AM