Page MenuHomePhabricator

[dagit] Clean up tables
ClosedPublic

Authored by dish on Dec 4 2020, 11:11 PM.

Details

Summary

Clean up a few tables in Dagit. They have a tendency to overflow the window, in part because of the no-wrap behavior in the cells. I don't think we need this, so I'm removing it.

Test Plan

View tables throughout Dagit, verify that they render better now.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Dec 4 2020, 11:16 PM
This revision is now accepted and ready to land.Dec 7 2020, 3:47 PM
js_modules/dagit/src/workspace/RepositoryPipelinesList.tsx
25

[1] We should add a limit of 10 here so that we don't over-fetch.

97

Related comment at [1]: I think we should limit the number of results in the query instead of just slicing here.

It could also be nice to have a + XYZ more link that deep links to the runs page filter for this pipeline so it's easy to see the total number of runs for the pipeline as well as how quickly access all the runs.

Good call on the limits, I'll add that in a followup.

This revision was automatically updated to reflect the committed changes.