Page MenuHomePhabricator

[dagit] Repair breadcrumb links in TopNav
ClosedPublic

Authored by dish on Dec 3 2020, 10:42 PM.

Details

Summary

Breadcrumb links in the top nav currently use Blueprint's default link rendering, which is not a react-router link. Fix this so that breadcrumb navigation doesn't constantly reload the page.

Test Plan

View Dagit, navigate via breadcrumbs. Verify proper link, hover, etc. rendering and behavior.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Dec 3 2020, 10:47 PM
sashank added inline comments.
js_modules/dagit/src/nav/TopNav.tsx
75–80

I didn't realize you could do all this in styled components, nice

This revision is now accepted and ready to land.Dec 7 2020, 3:53 PM
This revision was automatically updated to reflect the committed changes.