Page MenuHomePhabricator
Differential D5411

[dagit] Repair breadcrumb links in TopNav
ClosedPublic
Actions

Authored by dish on Dec 3 2020, 10:42 PM.

Details

Reviewers
bengotow
sashank
prha
Commits
R1:f9e0167dc200: [dagit] Repair breadcrumb links in TopNav
Summary

Breadcrumb links in the top nav currently use Blueprint's default link rendering, which is not a react-router link. Fix this so that breadcrumb navigation doesn't constantly reload the page.

Test Plan

View Dagit, navigate via breadcrumbs. Verify proper link, hover, etc. rendering and behavior.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.Dec 3 2020, 10:42 PM
Harbormaster completed remote builds in B22178: Diff 26939.Dec 3 2020, 10:47 PM
dish requested review of this revision.Dec 3 2020, 10:47 PM
dish updated this revision to Diff 27091.Dec 7 2020, 3:24 PM

Rebase

Harbormaster completed remote builds in B22305: Diff 27091.Dec 7 2020, 3:31 PM
sashank accepted this revision.Dec 7 2020, 3:53 PM
sashank added inline comments.
js_modules/dagit/src/nav/TopNav.tsx
75–80

I didn't realize you could do all this in styled components, nice

This revision is now accepted and ready to land.Dec 7 2020, 3:53 PM
Closed by commit R1:f9e0167dc200: [dagit] Repair breadcrumb links in TopNav (authored by dish). · Explain WhyDec 7 2020, 4:18 PM
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:f9e0167dc200: [dagit] Repair breadcrumb links in TopNav.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
nav/
62 lines

Diff 27104

View Options

js_modules/dagit/src/nav/TopNav.tsx

Loading...