Page MenuHomePhabricator

[dagit] Avoid flashing progress bar in Loading
ClosedPublic

Authored by dish on Dec 3 2020, 10:08 PM.

Details

Summary

The Loading component currently shows a progress bar during the loading state of the supplied queryData. This often means a brief flash of the progress bar, then the fully rendered child of the Loading component. This can be jarring, and is often unnecessary.

Instead, wait a brief moment during loading before showing the progress bar. If the loading completes during that wait, the contents render without the progress bar flash. If the loading does not complete during the wait, show the progress bar as normal while the loading finishes.

Test Plan

View a bunch of pages on Dagit that use Loading. Verify that when loading is completed quickly, the progress bar does not flash.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.