Page MenuHomePhabricator

[dagit] Fix phantom overlay in playground
ClosedPublic

Authored by dish on Dec 2 2020, 6:13 PM.

Details

Summary

On the Playground, the "loading" overlay is rendered whether anything is loading or not. My recent change to pointer-events now prevents clicks from making it through to the controls underneath.

Instead, just don't render the loading overlay if it's not loading.

Test Plan

View Playground, verify that I can click on the "Launch Execution" button.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.