Page MenuHomePhabricator
Differential D5359

[dagit] Fix clicks on loading overlay
ClosedPublic
Actions

Authored by dish on Dec 1 2020, 10:11 PM.

Details

Reviewers
bengotow
sashank
prha
Commits
R1:4c5b90296470: [dagit] Fix clicks on loading overlay
Summary

Resolves #3007

Fix clicks on the loading overlays in Dagit playground. The overlay should observe all pointer events, not allow them through.

Test Plan

View Playground, force loading overlay to appear. Verify that I can't click anything underneath it.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.Dec 1 2020, 10:11 PM
dish edited the summary of this revision. (Show Details)Dec 1 2020, 10:11 PM
Harbormaster completed remote builds in B21992: Diff 26702.Dec 1 2020, 10:17 PM
dish requested review of this revision.Dec 1 2020, 10:17 PM
sashank accepted this revision.Dec 2 2020, 7:41 AM
This revision is now accepted and ready to land.Dec 2 2020, 7:41 AM
dish updated this revision to Diff 26794.Dec 2 2020, 4:12 PM

Rebase, put this on a proper branch lol

This revision was landed with ongoing or failed builds.Dec 2 2020, 4:13 PM
Closed by commit R1:4c5b90296470: [dagit] Fix clicks on loading overlay (authored by dish). · Explain Why
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:4c5b90296470: [dagit] Fix clicks on loading overlay.
Harbormaster completed remote builds in B22070: Diff 26794.Dec 2 2020, 4:17 PM

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
execute/
1 line

Diff 26795

View Options

js_modules/dagit/src/execute/ExecutionSessionContainer.tsx

Loading...