Page MenuHomePhabricator

Fix small issues impacting Partition UI #3233, #3173, #2547
ClosedPublic

Authored by bengotow on Dec 1 2020, 4:58 PM.

Details

Summary

Run matrix failure percentages should use partitions with at least one run as denominator #3233

Use usePersistedQueryState hook for partitions view

when backfilling a subselection, auto-filter to that subselection #3173

Collect hardcoded dagster/ tags into a proper enum #2547

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 1 2020, 5:01 PM
Harbormaster failed remote builds in B21934: Diff 26629!
prha added inline comments.
js_modules/dagit/src/runs/RunTag.tsx
7–16

nice

This revision is now accepted and ready to land.Dec 3 2020, 4:53 PM