Page MenuHomeElementl
Differential D5345

Add missing type parameter annotations to useMutation/useQuery
ClosedPublic
Actions

Authored by • dish on Dec 1 2020, 4:47 PM.

Details

Reviewers
• bengotow
• sashank
• prha
Commits
R1:9dcb75ad232e: Add missing type parameter annotations to useMutation/useQuery
Summary

Found a few places in code where we don't have type annotations on useMutation and useQuery, adding them here and fixing type errors that surface.

Test Plan

yarn ts

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Dec 1 2020, 4:47 PM
Harbormaster completed remote builds in B21933: Diff 26628.Dec 1 2020, 4:52 PM
• dish requested review of this revision.Dec 1 2020, 4:52 PM
• sashank accepted this revision.Dec 1 2020, 5:08 PM
• sashank added inline comments.
js_modules/dagit/src/runs/RunActionsMenu.tsx
208–213

Should both of these if statements in this file have an else case? Something like

showToastFor(result, `Something went wrong when trying to delete Run ${run.runId}.`);
This revision is now accepted and ready to land.Dec 1 2020, 5:08 PM
• dish updated this revision to Diff 26637.Dec 1 2020, 5:52 PM

+sashank

• dish marked an inline comment as done.Dec 1 2020, 5:52 PM
• dish updated this revision to Diff 26639.Dec 1 2020, 5:55 PM

Rebase

Harbormaster completed remote builds in B21941: Diff 26637.Dec 1 2020, 5:57 PM
Harbormaster completed remote builds in B21942: Diff 26639.Dec 1 2020, 6:00 PM
• dish updated this revision to Diff 26641.Dec 1 2020, 6:03 PM

Rebase

Harbormaster completed remote builds in B21943: Diff 26641.Dec 1 2020, 6:08 PM
Closed by commit R1:9dcb75ad232e: Add missing type parameter annotations to useMutation/useQuery (authored by • dish). · Explain WhyDec 1 2020, 7:00 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:9dcb75ad232e: Add missing type parameter annotations to useMutation/useQuery.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
assets/
3 lines
7 lines
execute/
9 lines
partitions/
3 lines
runs/
6 lines
50 lines
schedules/
8 lines
20 lines
36 lines
snapshots/
4 lines

Diff 26642

View Options

js_modules/dagit/src/assets/AssetEntryRoot.tsx

Loading...
View Options

js_modules/dagit/src/assets/AssetsCatalogTable.tsx

Loading...
View Options

js_modules/dagit/src/execute/LaunchRootExecutionButton.tsx

Loading...
View Options

js_modules/dagit/src/partitions/PartitionsBackfill.tsx

Loading...
View Options

js_modules/dagit/src/runs/RunActionButtons.tsx

Loading...
View Options

js_modules/dagit/src/runs/RunActionsMenu.tsx

Loading...
View Options

js_modules/dagit/src/schedules/ReconcileButton.tsx

Loading...
View Options

js_modules/dagit/src/schedules/ScheduleDetails.tsx

Loading...
View Options

js_modules/dagit/src/schedules/ScheduleRow.tsx

Loading...
View Options

js_modules/dagit/src/snapshots/SnapshotNav.tsx

Loading...