Page MenuHomeElementl

Add missing type parameter annotations to useMutation/useQuery
ClosedPublic

Authored by dish on Dec 1 2020, 4:47 PM.

Details

Summary

Found a few places in code where we don't have type annotations on useMutation and useQuery, adding them here and fixing type errors that surface.

Test Plan

yarn ts

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Dec 1 2020, 4:52 PM
sashank added inline comments.
js_modules/dagit/src/runs/RunActionsMenu.tsx
208–213

Should both of these if statements in this file have an else case? Something like

showToastFor(result, `Something went wrong when trying to delete Run ${run.runId}.`);
This revision is now accepted and ready to land.Dec 1 2020, 5:08 PM
dish marked an inline comment as done.Dec 1 2020, 5:52 PM