Page MenuHomePhabricator
Differential D5343

[dagit] Replace ButtonLink uses
ClosedPublic
Actions

Authored by dish on Dec 1 2020, 4:34 PM.

Details

Reviewers
sashank
bengotow
Commits
R1:f7a5abe48aa9: [dagit] Replace ButtonLink uses
Summary

Replace existing ButtonLink use cases with the ButtonLink component I created the other day, which has some options around color and underline behavior.

Test Plan

View each use case in Dagit, verify proper rendering.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.Dec 1 2020, 4:34 PM
Harbormaster completed remote builds in B21931: Diff 26626.Dec 1 2020, 4:40 PM
dish requested review of this revision.Dec 1 2020, 4:40 PM
sashank accepted this revision.Dec 1 2020, 5:17 PM

Nice! Thanks for this :)

This revision is now accepted and ready to land.Dec 1 2020, 5:17 PM
Closed by commit R1:f7a5abe48aa9: [dagit] Replace ButtonLink uses (authored by dish). · Explain WhyDec 1 2020, 5:54 PM
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:f7a5abe48aa9: [dagit] Replace ButtonLink uses.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
execute/
4 lines
nav/
24 lines
partitions/
2 lines
schedules/
20 lines
ui/
6 lines
workspace/
30 lines

Diff 26638

View Options

js_modules/dagit/src/ButtonLink.tsx

Loading...
View Options

js_modules/dagit/src/execute/RunPreview.tsx

Loading...
View Options

js_modules/dagit/src/nav/RepositoryLocationStateObserver.tsx

Loading...
View Options

js_modules/dagit/src/partitions/PartitionsBackfill.tsx

Loading...
View Options

js_modules/dagit/src/schedules/ScheduleRow.tsx

Loading...
View Options

js_modules/dagit/src/ui/ButtonLink.tsx

Loading...
View Options

js_modules/dagit/src/workspace/WorkspaceRepositoryLocationsRoot.tsx

Loading...