Page MenuHomeElementl

[dagit] Surface errors on backfill mutation
ClosedPublic

Authored by dish on Nov 30 2020, 11:05 PM.

Details

Summary

Resolves #3262.

When errors are returned from GraphQL when kicking off a backfill, we currently swallow the errors. Instead, display them more aggressively.

This isn't a great long term solution, but we also don't have really good ways of consistently surfacing stack traces in Dagit UI. It's certainly better than nothing though.

Test Plan

Create a schedule that uses an invalid mode, try to kick off a backfill for it. Verify that the error appears.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Nov 30 2020, 11:11 PM

awesome, looks good! just one small comment

js_modules/dagit/src/partitions/PartitionsBackfill.tsx
199

If we don't have result.message, should we still show a message like "something bad happened and the backfill was not successfully launched, plz report bug to dagster"

This revision is now accepted and ready to land.Dec 1 2020, 6:35 AM

Add generic message on unknown failure, add a link to view the error

This revision was automatically updated to reflect the committed changes.