[dagit] Surface errors on backfill mutation
ClosedPublic
Actions

Authored by • dish on Nov 30 2020, 11:05 PM.

Details

Reviewers

• catherinewu
• sandyryza

Commits

R1:4253bc949afb: [dagit] Surface errors on backfill mutation

Summary

Resolves #3262.

When errors are returned from GraphQL when kicking off a backfill, we currently swallow the errors. Instead, display them more aggressively.

This isn't a great long term solution, but we also don't have really good ways of consistently surfacing stack traces in Dagit UI. It's certainly better than nothing though.

Test Plan

Create a schedule that uses an invalid mode, try to kick off a backfill for it. Verify that the error appears.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.Nov 30 2020, 11:05 PM

Screen Shot 2020-11-30 at 4.38.04 PM.png (1×1 px, 303 KB)

Harbormaster completed remote builds in B21897: Diff 26591.Nov 30 2020, 11:11 PM

• dish requested review of this revision.Nov 30 2020, 11:11 PM

awesome, looks good! just one small comment

js_modules/dagit/src/partitions/PartitionsBackfill.tsx
199	If we don't have result.message, should we still show a message like "something bad happened and the backfill was not successfully launched, plz report bug to dagster"

This revision is now accepted and ready to land.Dec 1 2020, 6:35 AM

Add generic message on unknown failure, add a link to view the error

Harbormaster completed remote builds in B21927: Diff 26622.Dec 1 2020, 4:19 PM

Rebase

Harbormaster completed remote builds in B21944: Diff 26643.Dec 1 2020, 7:07 PM

Closed by commit R1:4253bc949afb: [dagit] Surface errors on backfill mutation (authored by • dish). · Explain WhyDec 1 2020, 7:32 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:4253bc949afb: [dagit] Surface errors on backfill mutation.