Page MenuHomeElementl

[dagit] Tweak Schedule root details
ClosedPublic

Authored by dish on Nov 30 2020, 8:43 PM.

Details

Summary

Modify ScheduleRoot:

  • Remove id, which doesn't appear to be useful to anyone
  • Remove "Next tick" for "off" schedules
  • Move "Next tick" next to switch for "on" schedules
  • Add polling to Runs list
Test Plan

View Schedule, verify behavior descibed above.

Diff Detail

Repository
R1 dagster
Branch
dish-next-tick
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

this looks good, but ID is useful for one specific thing right now - debugging issues with the cron scheduler (the logs go in folders using the ID). We could make it less prominent but until we come to a final decision about whether we're killing SystemCronScheduler in this release I think it should still be available somewhere in dagit that we can direct users to during debugging.

This revision now requires changes to proceed.Nov 30 2020, 11:16 PM

Cool, I'll keep it around but make it less prominent.

Add ID back, make it copyable

sure - the slice makes it a little trickier to find, but it's kind of an edge-case-y debugging flow anyways. Thanks for adjusting

This revision is now accepted and ready to land.Dec 1 2020, 4:40 PM
This revision was automatically updated to reflect the committed changes.