Page MenuHomeElementl

[dagit] Tweak Schedule root details
ClosedPublic

Authored by dish on Nov 30 2020, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 2, 3:33 AM
Unknown Object (File)
Sat, Jun 25, 6:46 AM
Unknown Object (File)
Fri, Jun 17, 4:37 AM
Unknown Object (File)
Sun, Jun 12, 2:33 PM
Unknown Object (File)
Tue, Jun 7, 5:11 AM
Unknown Object (File)
May 30 2022, 9:03 AM
F441131: Schedule ID copy.mov
Nov 30 2020, 11:44 PM
Subscribers
None

Details

Summary

Modify ScheduleRoot:

  • Remove id, which doesn't appear to be useful to anyone
  • Remove "Next tick" for "off" schedules
  • Move "Next tick" next to switch for "on" schedules
  • Add polling to Runs list
Test Plan

View Schedule, verify behavior descibed above.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

this looks good, but ID is useful for one specific thing right now - debugging issues with the cron scheduler (the logs go in folders using the ID). We could make it less prominent but until we come to a final decision about whether we're killing SystemCronScheduler in this release I think it should still be available somewhere in dagit that we can direct users to during debugging.

This revision now requires changes to proceed.Nov 30 2020, 11:16 PM

Cool, I'll keep it around but make it less prominent.

Add ID back, make it copyable

sure - the slice makes it a little trickier to find, but it's kind of an edge-case-y debugging flow anyways. Thanks for adjusting

This revision is now accepted and ready to land.Dec 1 2020, 4:40 PM
This revision was automatically updated to reflect the committed changes.