Page MenuHomePhabricator

Excise six.string_types
ClosedPublic

Authored by max on Nov 30 2020, 7:56 PM.

Details

Summary

Simplifies check logic by removing py2 checks

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2020, 8:05 PM
Harbormaster failed remote builds in B21882: Diff 26569!
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2020, 9:21 PM
Harbormaster failed remote builds in B21887: Diff 26575!
max requested review of this revision.Nov 30 2020, 10:09 PM

do we ever want to open source check with py2 compat? (i added f-strings to check but still asking the question)

schrockn requested changes to this revision.Dec 1 2020, 6:42 PM

req'ing changes so it is in your queue

This revision now requires changes to proceed.Dec 1 2020, 6:42 PM
max requested review of this revision.Dec 1 2020, 8:23 PM

No, I don't think so -- the only reason to have check be py2 compat if it were open sourced would be to help people doing migrations from 2->3 but I get a feeling the big ones are done/people would write their own custom tooling.

cool. very happy to see this gone

This revision is now accepted and ready to land.Dec 1 2020, 8:27 PM
This revision was automatically updated to reflect the committed changes.