Excise six.string_types
ClosedPublic
Actions

Authored by max on Nov 30 2020, 7:56 PM.

Details

Reviewers

schrockn
alangenfeld

Commits

R1:47ee18cb31a9: Excise six.string_types

Summary

Simplifies check logic by removing py2 checks

Test Plan

Unit

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Nov 30 2020, 7:56 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2020, 8:05 PM

Harbormaster failed remote builds in B21882: Diff 26569!

lint

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2020, 9:21 PM

Harbormaster failed remote builds in B21887: Diff 26575!

fix test setup

Harbormaster completed remote builds in B21890: Diff 26581.Nov 30 2020, 10:09 PM

max requested review of this revision.Nov 30 2020, 10:09 PM

do we ever want to open source check with py2 compat? (i added f-strings to check but still asking the question)

req'ing changes so it is in your queue

This revision now requires changes to proceed.Dec 1 2020, 6:42 PM

No, I don't think so -- the only reason to have check be py2 compat if it were open sourced would be to help people doing migrations from 2->3 but I get a feeling the big ones are done/people would write their own custom tooling.

cool. very happy to see this gone

This revision is now accepted and ready to land.Dec 1 2020, 8:27 PM

Closed by commit R1:47ee18cb31a9: Excise six.string_types (authored by max). · Explain WhyDec 3 2020, 7:07 PM

This revision was automatically updated to reflect the committed changes.

max added a commit: R1:47ee18cb31a9: Excise six.string_types.

Revision Contents
Changeset List

Path

Size

examples/

legacy_examples/

dagster_examples/

event_pipeline_demo/

pipelines.py

3 lines

python_modules/

automation/

release/

dagster_module.py

3 lines

dagster/

check/

39 lines

cli/

3 lines

3 lines

3 lines

workspace/

load.py

7 lines

config/

source.py

3 lines

validate.py

4 lines

core/

code_pointer.py

2 lines

definitions/

events.py

7 lines

solid_container.py

9 lines

utils.py

4 lines

execution/

results.py

3 lines

selector/

subset_selector.py

4 lines

telemetry.py

3 lines

types/

dagster_type.py

4 lines

utils/

__init__.py

4 lines

dagster_tests/

core_tests/

config_types_tests/

test_field_hash.py

3 lines

general_tests/

check_tests/

test_check.py

2 lines

libraries/

dagstermill/

solids.py

3 lines

Diff 26926

View Options

examples/legacy_examples/dagster_examples/event_pipeline_demo/pipelines.py

View Options

python_modules/automation/automation/release/dagster_module.py

View Options

python_modules/dagster/dagster/check/init.py

View Options

python_modules/dagster/dagster/check/utils.py

View Options

python_modules/dagster/dagster/cli/pipeline.py

View Options

python_modules/dagster/dagster/cli/schedule.py

View Options

python_modules/dagster/dagster/cli/sensor.py

View Options

python_modules/dagster/dagster/cli/workspace/load.py

View Options

python_modules/dagster/dagster/config/source.py

View Options

python_modules/dagster/dagster/config/validate.py

View Options

python_modules/dagster/dagster/core/code_pointer.py

View Options

python_modules/dagster/dagster/core/definitions/events.py

View Options

python_modules/dagster/dagster/core/definitions/solid_container.py

View Options

python_modules/dagster/dagster/core/definitions/utils.py

View Options

python_modules/dagster/dagster/core/execution/results.py

View Options

python_modules/dagster/dagster/core/selector/subset_selector.py

View Options

python_modules/dagster/dagster/core/telemetry.py

View Options

python_modules/dagster/dagster/core/types/dagster_type.py

View Options

python_modules/dagster/dagster/utils/init.py

View Options

python_modules/dagster/dagster_tests/core_tests/config_types_tests/test_field_hash.py

View Options

python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.py

View Options

python_modules/libraries/dagstermill/dagstermill/solids.py

Excise six.string_typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26926

examples/legacy_examples/dagster_examples/event_pipeline_demo/pipelines.py

python_modules/automation/automation/release/dagster_module.py

python_modules/dagster/dagster/check/__init__.py

python_modules/dagster/dagster/check/utils.py

python_modules/dagster/dagster/cli/pipeline.py

python_modules/dagster/dagster/cli/schedule.py

python_modules/dagster/dagster/cli/sensor.py

python_modules/dagster/dagster/cli/workspace/load.py

python_modules/dagster/dagster/config/source.py

python_modules/dagster/dagster/config/validate.py

python_modules/dagster/dagster/core/code_pointer.py

python_modules/dagster/dagster/core/definitions/events.py

python_modules/dagster/dagster/core/definitions/solid_container.py

python_modules/dagster/dagster/core/definitions/utils.py

python_modules/dagster/dagster/core/execution/results.py

python_modules/dagster/dagster/core/selector/subset_selector.py

python_modules/dagster/dagster/core/telemetry.py

python_modules/dagster/dagster/core/types/dagster_type.py

python_modules/dagster/dagster/utils/__init__.py

python_modules/dagster/dagster_tests/core_tests/config_types_tests/test_field_hash.py

python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.py

python_modules/libraries/dagstermill/dagstermill/solids.py

Excise six.string_types
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster/dagster/check/init.py

python_modules/dagster/dagster/utils/init.py