Page MenuHomePhabricator

[dagit] Confirmation for run deletion

Authored by dish on Nov 30 2020, 5:16 PM.



Relates to #3236.

Add a confirmation dialog when batch deleting runs and remove canTerminate as a criteria for deletability.

When runs are successfully deleted, show a single toast. When any fail, show toasts for each of the failures.

Test Plan

Delete runs from the Runs page, verify that the confirmation dialog appears and behaves correctly. Verify that deletion shows the appropriate toasts.

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Nov 30 2020, 5:21 PM

Gonna add some more context here.

A bunch of changes, will post screenshots inline.

The user attempts to terminate a batch of runs. Show a dialog.

Upon confirmation, termination occurs with an animated progress bar. Successes are displayed, and errors appear beneath that.

Example with errors:

Here, the user attempts to *delete* a batch of runs. If any can be terminated, we suggest they do that instead. Clicking to do so will open the termination dialog in place of the deletion dialog, and they can use that flow.

If no runs can be terminated, the dialog is a bit simpler:

If they choose to continue with deletion, it looks similar to the termination flow.

Add navigation blocking and messages asking the user not to close the window.

Reset dialogs upon reopening

nice reducer!! this looks awesome.

Macro pooh_eating_honey:

for the future, should we track a list of "batch action" mutations to add? previously "batch action" mutations also came up for asset / partitions UIs

This revision is now accepted and ready to land.Dec 3 2020, 1:14 AM

Rebase, grammar cleanup, add error case to DeletionDialog storybook

Don't gate deletion on canTerminate

This revision was automatically updated to reflect the committed changes.