Page MenuHomeElementl

Make Noneable types make fields become optional by default
ClosedPublic

Authored by schrockn on Nov 30 2020, 12:57 AM.

Details

Summary

Before this change, fields were automatically made default only
if they were Shapes or Selectors. However, any Noneable type should be
optional and default to None. This came up during asset store/input
output manager exploration.

This is not a breaking change w/r/t to config schema, because this is
strictly more permissive. However this could potentially break anyone
who has built tooling on top of the config system.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schrockn retitled this revision from Make Noneable types make fields becomes optional to Make Noneable types make fields become optional by default.
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: sandyryza, max, dgibson.

up

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2020, 1:53 AM
Harbormaster failed remote builds in B21846: Diff 26530!

better late than never :) this seems reasonable

This revision is now accepted and ready to land.Dec 21 2020, 6:26 PM