[dagit] Remove refetch from WorkspaceContext
ClosedPublic
Actions

Authored by sashank on Nov 25 2020, 11:07 PM.

Details

Reviewers

dish
alangenfeld

Commits

R1:7f9892212f91: [dagit] Remove refetch from WorkspaceContext

Summary

In D5299 we removed the use of refetch in the reload button. There is no longer a need to have refetch on the WorkspaceContext, so this diff removes it.

Test Plan

unit

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Nov 25 2020, 11:07 PM

Harbormaster failed remote builds in B21813: Diff 26495!Nov 25 2020, 11:13 PM

Harbormaster completed remote builds in B21814: Diff 26496.Nov 25 2020, 11:18 PM

sashank requested review of this revision.Nov 25 2020, 11:18 PM

alangenfeld accepted this revision.Nov 30 2020, 5:21 PM

This revision is now accepted and ready to land.Nov 30 2020, 5:21 PM

Closed by commit R1:7f9892212f91: [dagit] Remove refetch from WorkspaceContext (authored by sashank). · Explain WhyNov 30 2020, 6:51 PM

This revision was automatically updated to reflect the committed changes.

sashank added a commit: R1:7f9892212f91: [dagit] Remove refetch from WorkspaceContext.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

src/

workspace/

WorkspaceContext.test.tsx

23 lines

WorkspaceContext.tsx

6 lines

Diff 26563

View Options

js_modules/dagit/src/workspace/WorkspaceContext.test.tsx