Page MenuHomeElementl

adls2 asset store
ClosedPublic

Authored by cdecarolis on Nov 24 2020, 9:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 14, 7:34 AM
Unknown Object (File)
Mon, Nov 14, 3:43 AM
Unknown Object (File)
Sat, Nov 12, 3:35 PM
Unknown Object (File)
Sat, Nov 12, 2:33 PM
Unknown Object (File)
Sat, Nov 12, 1:42 PM
Unknown Object (File)
Sat, Nov 12, 1:07 PM
Unknown Object (File)
Sat, Nov 12, 8:22 AM
Unknown Object (File)
Sat, Nov 12, 7:25 AM
Subscribers
None

Details

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 24 2020, 9:59 PM
Harbormaster failed remote builds in B21709: Diff 26352!

build completed successfully, not sure why the hook didn't publish.

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_asset_store.py
47

nit: comma

54–58

see [1]

61–68
75

[1] should be able to do test_adls2_asset_store_execution(storage_account, file_system, credential) as credential is already set in conftest.py

90–109

why not just execute_pipeline?

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_asset_store.py
90–109

this way I have control over the run_id more easily, which allows me to construct asset store context on the fly

let's add the new asset stores in api docs rst so they can show up in the docs - can do it all at once with s3 and gcs apis in a follow up diff.

This revision is now accepted and ready to land.Dec 1 2020, 11:13 PM