Differential D5266

Deflake grpc server watch tests
ClosedPublic
Actions

Authored by sashank on Nov 24 2020, 5:28 PM.

Tags

None

Subscribers

None

Details

Reviewers

dgibson
alangenfeld

Commits

R1:b2f5185010ed: Deflake grpc server watch tests

Summary

Replace use of sleeps with timeout logic

Test Plan

unit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

up

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 24 2020, 5:48 PM

Harbormaster failed remote builds in B21664: Diff 26295!

Harbormaster failed remote builds in B21665: Diff 26296!

up

up

Harbormaster failed remote builds in B21671: Diff 26304!Nov 24 2020, 6:23 PM

Harbormaster completed remote builds in B21676: Diff 26310.Nov 24 2020, 6:33 PM

sashank requested review of this revision.Nov 24 2020, 6:33 PM

sashank added a reviewer: alangenfeld.Nov 24 2020, 6:38 PM

up

up

Harbormaster completed remote builds in B21681: Diff 26316.Nov 24 2020, 6:56 PM

Harbormaster completed remote builds in B21680: Diff 26315.

up

up

Harbormaster completed remote builds in B21685: Diff 26320.Nov 24 2020, 7:35 PM

Harbormaster completed remote builds in B21686: Diff 26321.Nov 24 2020, 7:41 PM

see suggestion inline for failing earlier when something unexpected happens (in this case, hitting the timeout)

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_watch_server.py
16	IMO this should throw an exception rather than just keep going?
109–110	if you make it throw if it times out, you don't need to check it again here, and you'll know sooner when it fails

This revision is now accepted and ready to land.Nov 24 2020, 7:46 PM

up

This revision was landed with ongoing or failed builds.Nov 24 2020, 8:08 PM

Closed by commit R1:b2f5185010ed: Deflake grpc server watch tests (authored by sashank). · Explain Why

This revision was automatically updated to reflect the committed changes.

sashank added a commit: R1:b2f5185010ed: Deflake grpc server watch tests.

Harbormaster completed remote builds in B21689: Diff 26326.Nov 24 2020, 8:10 PM

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster_tests/

general_tests/

grpc_tests/

test_watch_server.py

78 lines

Diff 26331

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_watch_server.py

Loading...