Page MenuHomeElementl

Deflake grpc server watch tests
ClosedPublic

Authored by sashank on Nov 24 2020, 5:28 PM.

Details

Summary

Replace use of sleeps with timeout logic

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 24 2020, 5:48 PM
Harbormaster failed remote builds in B21664: Diff 26295!
Harbormaster failed remote builds in B21665: Diff 26296!

see suggestion inline for failing earlier when something unexpected happens (in this case, hitting the timeout)

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_watch_server.py
16

IMO this should throw an exception rather than just keep going?

109–110

if you make it throw if it times out, you don't need to check it again here, and you'll know sooner when it fails

This revision is now accepted and ready to land.Nov 24 2020, 7:46 PM
This revision was landed with ongoing or failed builds.Nov 24 2020, 8:08 PM
This revision was automatically updated to reflect the committed changes.