Page MenuHomeElementl

[dagit] Repair endless scrolling Gaant
ClosedPublic

Authored by dish on Nov 23 2020, 10:51 PM.

Details

Summary

Resolves #3063

On a Run page, we are currently depending on filtered logs to determine the metadata for the Gantt chart, which means that if you filter out "Event", we no longer have our start and end times in the metadata, and the chart scrolls forever even after the run is complete.

Fix this by providing all of the nodes for metadata computation, rather than just the filtered nodes. I think this was probably an oversight when I made changes to log filtering a couple months ago.

Test Plan

Kick off a run, unselect "Event" in the logs toolbar. Verify that the Gaant shows the correct execution, and stops properly when the run completes.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

With this change, the Gaant will no longer be affected by filtering the logs. Is this the correct behavior?

dish requested review of this revision.Nov 23 2020, 10:57 PM

With this change, the Gaant will no longer be affected by filtering the logs. Is this the correct behavior?

I believe the only thing that affected the Gaant chart before this was the "Event" toggle, so this is definitely more correct.

This revision is now accepted and ready to land.Nov 23 2020, 11:23 PM
This revision was automatically updated to reflect the committed changes.