Page MenuHomeElementl

Add FutureTicks connection to ScheduleDefinition
ClosedPublic

Authored by dgibson on Nov 23 2020, 7:51 PM.

Details

Summary

Lets dagit iterate you through the future executions of a schedule. Depends on D5248.

Test Plan

New BK tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

python_modules/dagster-graphql/dagster_graphql/schema/schedules/__init__.py
53–57

this could also be ScheduleExpectedTick or something, in case we ever want to go into the past too

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2020, 8:12 PM
Harbormaster failed remote builds in B21623: Diff 26242!

This is very cool! Excited to see how this shows up in the UI

python_modules/dagster-graphql/dagster_graphql/schema/schedules/__init__.py
70

Should this be dauphin.Int? A UTC timestamp is in seconds so I don't think we're doing sub-second intervals.

python_modules/dagster-graphql/dagster_graphql/schema/schedules/schedule_definition.py
47

Same here re: dauphin.Int

This revision is now accepted and ready to land.Nov 23 2020, 11:36 PM

I think this looks good and we should merge to unblock the frontend.

I think we might be able to do a more generic JobTick that encompasses both future and past ticks, maybe with just a different status?

python_modules/dagster-graphql/dagster_graphql/schema/schedules/__init__.py
70

in python at least they're floats

datetime.datetime.now().timestamp()
1606230476.63741

@prha yeah I probably would have just called this DauphinScheduleTick if that name hadn't already been taken for ticks that have actually been stored :) (with a bunch of fields that don't necc. make sense for an expected/future one)