Page MenuHomePhabricator
Differential D5239

Eliminate old style classes
ClosedPublic
Actions

Authored by schrockn on Nov 21 2020, 2:02 PM.

Details

Reviewers
max
dgibson
alangenfeld
Commits
R1:18867720e7c3: Eliminate old style classes
Summary

Since we dropped Python 2 support, we no longer have to deal with old-style classes.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
kill-old-classes
Lint
Lint SkippedExcuse: slow
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Nov 21 2020, 2:02 PM
schrockn updated this revision to Diff 26181.Nov 21 2020, 2:13 PM

up

schrockn added a comment.Nov 21 2020, 2:17 PM

I'm not sure what the grpc changes are about. If I run python -m dagster.grpc.compile on master right now it produces changes

Harbormaster failed remote builds in B21576: Diff 26179!Nov 21 2020, 2:18 PM
schrockn updated this revision to Diff 26183.Nov 21 2020, 2:24 PM

up

Harbormaster failed remote builds in B21578: Diff 26181!Nov 21 2020, 2:33 PM
Harbormaster completed remote builds in B21580: Diff 26183.Nov 21 2020, 2:41 PM
schrockn requested review of this revision.Nov 21 2020, 2:41 PM
schrockn updated this revision to Diff 26186.Nov 21 2020, 2:58 PM
schrockn added reviewers: max, dgibson, alangenfeld.

up

Harbormaster completed remote builds in B21582: Diff 26186.Nov 21 2020, 3:16 PM
alangenfeld accepted this revision.Nov 23 2020, 4:13 PM

whynot

This revision is now accepted and ready to land.Nov 23 2020, 4:13 PM
schrockn updated this revision to Diff 26225.Nov 23 2020, 5:26 PM

rebase

schrockn updated this revision to Diff 26229.Nov 23 2020, 5:31 PM

up

Harbormaster failed remote builds in B21612: Diff 26225!Nov 23 2020, 5:43 PM
Harbormaster failed remote builds in B21614: Diff 26229!Nov 23 2020, 5:49 PM
schrockn updated this revision to Diff 26236.Nov 23 2020, 6:10 PM

up

schrockn updated this revision to Diff 26237.Nov 23 2020, 6:18 PM

up

schrockn updated this revision to Diff 26238.Nov 23 2020, 6:24 PM

up

Harbormaster failed remote builds in B21618: Diff 26236!Nov 23 2020, 6:27 PM
Harbormaster failed remote builds in B21619: Diff 26237!Nov 23 2020, 6:33 PM
Harbormaster completed remote builds in B21620: Diff 26238.Nov 23 2020, 6:41 PM
Closed by commit R1:18867720e7c3: Eliminate old style classes (authored by schrockn). · Explain WhyNov 23 2020, 7:03 PM
This revision was automatically updated to reflect the committed changes.
schrockn added a commit: R1:18867720e7c3: Eliminate old style classes.

Large Diff

This large diff affects 108 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
.buildkite/
2 lines
examples/
docs_snippets/
docs_snippets/
intro_tutorial/
advanced/
pipelines/
4 lines
4 lines
2 lines
2 lines
legacy_examples/
dagster_examples/
bay_bikes/
2 lines
dagster_examples_tests/
event_pipeline_demo_tests/
2 lines
python_modules/
automation/
automation/
8 lines
2 lines
release/
2 lines
dagit/
dagit_tests/
2 lines
dagster-graphql/
dagster_graphql/
2 lines
implementation/
2 lines
schema/
16 lines
22 lines
10 lines
123 lines
10 lines
16 lines
4 lines
22 lines
24 lines
113 lines
118 lines
schedules/
36 lines
21 lines
8 lines
32 lines
dagster-test/
dagster_test/
toys/
2 lines
dagster/
dagster/
2 lines
config/
2 lines
4 lines
2 lines
4 lines
2 lines
2 lines
2 lines
core/
2 lines
definitions/
8 lines
decorators/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
4 lines
execution/
2 lines
context/
2 lines
2 lines
plan/
2 lines
2 lines
2 lines
4 lines
executor/
2 lines
host_representation/
2 lines
storage/
2 lines
2 lines
2 lines
2 lines
system_config/
2 lines
types/
2 lines
4 lines
2 lines
2 lines
daemon/
2 lines
2 lines
grpc/
2 lines
4 lines
utils/
2 lines
2 lines
2 lines
dagster_tests/
core_tests/
definitions_tests/
2 lines
2 lines
execution_tests/
2 lines
runtime_types_tests/
8 lines
2 lines
2 lines
general_tests/
check_tests/
46 lines
py3_tests/
2 lines
libraries/
dagster-airflow/
dagster_airflow/
operators/
2 lines
dagster_airflow_tests/
test_factory/
2 lines
dagster-aws/
dagster_aws/
s3/
2 lines
2 lines
utils/
mrjob/
2 lines
dagster-azure/
dagster_azure/
adls2/
8 lines
2 lines
blob/
8 lines
dagster-celery/
dagster_celery/
2 lines
dagster-dask/
dagster_dask/
2 lines
dagster-gcp/
dagster_gcp/
dataproc/
2 lines
dagster-pagerduty/
dagster_pagerduty/
2 lines
dagster-pandas/
dagster_pandas/
4 lines
dagster-postgres/
dagster_postgres/
event_log/
2 lines
dagster-prometheus/
dagster_prometheus/
2 lines
dagster-pyspark/
dagster_pyspark/
2 lines
dagster-ssh/
dagster_ssh/
2 lines
dagstermill/
dagstermill/
examples/
4 lines
2 lines
dagstermill_tests/
2 lines

Diff 26225

View Options

.buildkite/step_builder.py

View Options

examples/docs_snippets/docs_snippets/intro_tutorial/advanced/pipelines/modes.py

View Options

examples/docs_snippets/docs_snippets/intro_tutorial/advanced/pipelines/presets.py

View Options

examples/docs_snippets/docs_snippets/intro_tutorial/advanced/pipelines/required_resources.py

View Options

examples/docs_snippets/docs_snippets/intro_tutorial/advanced/pipelines/resources.py

View Options

examples/legacy_examples/dagster_examples/bay_bikes/resources.py

View Options

examples/legacy_examples/dagster_examples_tests/event_pipeline_demo_tests/test_airflowized.py

View Options

python_modules/automation/automation/parse_dataproc_configs.py

View Options

python_modules/automation/automation/parse_spark_configs.py

View Options

python_modules/automation/automation/release/pypirc.py

View Options

python_modules/dagit/dagit_tests/test_app.py

View Options

python_modules/dagster-graphql/dagster_graphql/dauphin_registry.py

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/pipeline_run_storage.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/assets.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/config_types.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/dagster_types.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/execution.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/external.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/paging.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/partition_sets.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/pipelines.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/roots.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/runs.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/schedules/__init__.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/schedules/schedule_definition.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/schedules/schedule_state.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

View Options

python_modules/dagster-test/dagster_test/toys/error_monster.py

View Options

python_modules/dagster/dagster/builtins.py

View Options

python_modules/dagster/dagster/config/config_schema.py

View Options

python_modules/dagster/dagster/config/config_type.py

View Options

python_modules/dagster/dagster/config/field.py

View Options

python_modules/dagster/dagster/config/field_utils.py

View Options

python_modules/dagster/dagster/config/run_config.py

View Options

python_modules/dagster/dagster/config/stack.py

View Options

python_modules/dagster/dagster/config/traversal_context.py

View Options

python_modules/dagster/dagster/core/decorator_utils.py

View Options

python_modules/dagster/dagster/core/definitions/composition.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/composite_solid.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/hook.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/lambda_solid.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/pipeline.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/repository.py

View Options

python_modules/dagster/dagster/core/definitions/decorators/solid.py

View Options

python_modules/dagster/dagster/core/definitions/dependency.py

View Options

python_modules/dagster/dagster/core/definitions/executor.py

View Options

python_modules/dagster/dagster/core/definitions/input.py

View Options

python_modules/dagster/dagster/core/definitions/intermediate_storage.py

View Options

python_modules/dagster/dagster/core/definitions/job.py

View Options

python_modules/dagster/dagster/core/definitions/output.py

View Options

python_modules/dagster/dagster/core/definitions/reconstructable.py

View Options

python_modules/dagster/dagster/core/definitions/repository.py

View Options

python_modules/dagster/dagster/core/definitions/resource.py

View Options

python_modules/dagster/dagster/core/definitions/system_storage.py

View Options

python_modules/dagster/dagster/core/execution/api.py

View Options

python_modules/dagster/dagster/core/execution/context/step.py

View Options

python_modules/dagster/dagster/core/execution/context/system.py

View Options

python_modules/dagster/dagster/core/execution/plan/active.py

View Options

python_modules/dagster/dagster/core/execution/plan/plan.py

View Options

python_modules/dagster/dagster/core/execution/resources_init.py

View Options

python_modules/dagster/dagster/core/execution/results.py

View Options

python_modules/dagster/dagster/core/executor/child_process_executor.py

View Options

python_modules/dagster/dagster/core/host_representation/grpc_server_state_subscriber.py

View Options

python_modules/dagster/dagster/core/storage/compute_log_manager.py

View Options

python_modules/dagster/dagster/core/storage/local_compute_log_manager.py

View Options

python_modules/dagster/dagster/core/storage/temp_file_manager.py

View Options

python_modules/dagster/dagster/core/storage/type_storage.py

View Options

python_modules/dagster/dagster/core/system_config/objects.py

View Options

python_modules/dagster/dagster/core/types/builtin_config_schemas.py

View Options

python_modules/dagster/dagster/core/types/config_schema.py

View Options

python_modules/dagster/dagster/core/types/dagster_type.py

View Options

python_modules/dagster/dagster/core/types/python_dict.py

View Options

python_modules/dagster/dagster/daemon/controller.py

View Options

python_modules/dagster/dagster/daemon/daemon.py

View Options

python_modules/dagster/dagster/grpc/client.py

View Options

python_modules/dagster/dagster/grpc/server.py

View Options

python_modules/dagster/dagster/utils/__init__.py

View Options

python_modules/dagster/dagster/utils/indenting_printer.py

View Options

python_modules/dagster/dagster/utils/timing.py

View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_definition_errors.py

View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_pipeline.py

View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_custom_reconstructable.py

View Options

python_modules/dagster/dagster_tests/core_tests/runtime_types_tests/test_dagster_type_decorator.py

View Options

python_modules/dagster/dagster_tests/core_tests/runtime_types_tests/test_types.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_composites.py

View Options

python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.py

View Options

python_modules/dagster/dagster_tests/general_tests/py3_tests/test_inference.py

View Options

python_modules/libraries/dagster-airflow/dagster_airflow/operators/docker_operator.py

View Options

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_factory/test_pipeline_run_creation.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/s3/s3_fake_resource.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/s3/utils.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/utils/mrjob/retry.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/adls2/fake_adls2_resource.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/adls2/resources.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/blob/fake_blob_client.py

View Options

python_modules/libraries/dagster-celery/dagster_celery/config.py

View Options

python_modules/libraries/dagster-dask/dagster_dask/resources.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp/dataproc/resources.py

View Options

python_modules/libraries/dagster-pagerduty/dagster_pagerduty/resources.py

View Options

python_modules/libraries/dagster-pandas/dagster_pandas/constraints.py

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

View Options

python_modules/libraries/dagster-prometheus/dagster_prometheus/resources.py

View Options

python_modules/libraries/dagster-pyspark/dagster_pyspark/resources.py

View Options

python_modules/libraries/dagster-ssh/dagster_ssh/resources.py

View Options

python_modules/libraries/dagstermill/dagstermill/examples/repository.py

View Options

python_modules/libraries/dagstermill/dagstermill/manager.py

View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_manager.py