Page MenuHomePhabricator
Differential D5228

[sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason
ClosedPublic
Actions

Authored by prha on Nov 20 2020, 10:17 PM.

Details

Reviewers
dgibson
schrockn
sandyryza
alangenfeld
Commits
R1:a88b71f9eba9: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

prha created this revision.Nov 20 2020, 10:17 PM
prha updated this revision to Diff 26111.Nov 20 2020, 10:29 PM

update

Harbormaster failed remote builds in B21512: Diff 26105!Nov 20 2020, 10:30 PM
Harbormaster completed remote builds in B21518: Diff 26111.Nov 20 2020, 10:43 PM
prha requested review of this revision.Nov 20 2020, 10:43 PM
prha updated this revision to Diff 26288.Nov 24 2020, 4:02 PM

update

prha retitled this revision from RFC: rename SensorRunParams/SensorSkipData => RunParams/RunSkippedData to [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.Nov 24 2020, 4:12 PM
prha added reviewers: dgibson, schrockn, sandyryza, alangenfeld.
Harbormaster failed remote builds in B21657: Diff 26288!Nov 24 2020, 4:18 PM
dgibson accepted this revision.Nov 24 2020, 4:57 PM

seems reasonable to me, assuming we have something close to consensus that this is a good way forward

python_modules/dagster/dagster/core/definitions/sensor.py
47

s/body//g

48

what is an ExecutionDefinition? Is that what Job is becoming?

This revision is now accepted and ready to land.Nov 24 2020, 4:57 PM
prha updated this revision to Diff 26294.Nov 24 2020, 5:12 PM

pylint

Harbormaster completed remote builds in B21663: Diff 26294.Nov 24 2020, 5:29 PM
prha updated this revision to Diff 26307.Nov 24 2020, 6:10 PM

rename execution_key => run_key

Harbormaster failed remote builds in B21673: Diff 26307!Nov 24 2020, 6:28 PM
prha updated this revision to Diff 26342.Nov 24 2020, 9:12 PM

update

Harbormaster completed remote builds in B21701: Diff 26342.Nov 24 2020, 9:30 PM
Closed by commit R1:a88b71f9eba9: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason (authored by prha). · Explain WhyNov 24 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.
prha added a commit: R1:a88b71f9eba9: [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
implementation/
6 lines
dagster/
dagster/
core/
definitions/
decorators/
14 lines
3 lines
74 lines
host_representation/
4 lines
grpc/
8 lines
dagster_tests/
api_tests/
6 lines
cli_tests/
command_tests/
4 lines
scheduler_tests/
10 lines

Diff 26105

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_schedules.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/decorators/sensor.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/job.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/sensor.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/external_data.py

Loading...
View Options

python_modules/dagster/dagster/grpc/impl.py

Loading...
View Options

python_modules/dagster/dagster_tests/api_tests/api_tests_repo.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_cli_commands.py

Loading...
View Options

python_modules/dagster/dagster_tests/scheduler_tests/test_sensor_run.py

Loading...