Page MenuHomePhabricator

[sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason
ClosedPublic

Authored by prha on Fri, Nov 20, 10:17 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha requested review of this revision.Fri, Nov 20, 10:43 PM
prha retitled this revision from RFC: rename SensorRunParams/SensorSkipData => RunParams/RunSkippedData to [sensors-7.5] rename SensorRunParams/SensorSkipData => RunRequest/SkipReason.Tue, Nov 24, 4:12 PM

seems reasonable to me, assuming we have something close to consensus that this is a good way forward

python_modules/dagster/dagster/core/definitions/sensor.py
47

s/body//g

48

what is an ExecutionDefinition? Is that what Job is becoming?

This revision is now accepted and ready to land.Tue, Nov 24, 4:57 PM

rename execution_key => run_key